Issue 149474: Expand status bubble to accommodate long URLs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149474: Expand status bubble to accommodate long URLs.... (Closed)

Created:
11 years, 5 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), chromium-reviews, ben+cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Change hover time to 1600 ms, and resize more quickly for smaller width change. BUG=1455 TEST= hover over link which is too long for status bubble. bubble should expand. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46235

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+224 lines, -9 lines)			Patch
M	chrome/browser/cocoa/status_bubble_mac.h	View	1 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/status_bubble_mac.mm	View	1 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/status_bubble_gtk.h	View	4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/status_bubble_gtk.cc	View	4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/status_bubble.h	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/status_bubble_views.h	View	1 2 3 4 5 6 7	6 chunks	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/views/status_bubble_views.cc	View	1 2 3 4 5 6 7	10 chunks	+172 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Miranda Callahan

Glen, you reviewed a patch very similar to this one last year. There were reliability ...

10 years, 8 months ago (2010-03-30 23:33:57 UTC) #1

Miranda Callahan

(Things I fixed were memory allocation issues -- putting the expander code in a scoped_ptr, ...

10 years, 8 months ago (2010-03-30 23:35:16 UTC) #2

Glen Murphy

10 years, 8 months ago (2010-04-02 00:06:21 UTC) #3

LGTM with 1600ms and EASE_IN_OUT changes discussed in person.