Issue 149437: Linux: don't crash when performing font fallback to a non-scalable font.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149437: Linux: don't crash when performing font fallback to a non-scalable font. (Closed)

Created:
11 years, 5 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, Lei Zhang

Visibility:
Public.

Description

Linux: don't crash when performing font fallback to a non-scalable font. Previously we were filtering out non-scalable fonts /after/ the fact. This patch changes it so that we specify to fontconfig that it shouldn't return non-scalable fonts to us. We also duplicate this code into WebFontInfo so that we don't get these issues when performing glyph-fallback.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	skia/ext/SkFontHost_fontconfig_direct.cpp	View		2 chunks	+4 lines, -10 lines	0 comments	Download
	M	webkit/api/src/gtk/WebFontInfo.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages