Issue 149429: ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149429: ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED (Closed)

Created:
11 years, 5 months ago by rafaelw

Modified:
9 years, 6 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED. This became necessary with the addition of dockable devtools TabContents. It is now possible for Tab contents to close after having been detached without being re-attached to a browser (as in the case of docking). TBR=pfeldman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20387

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR changes #

Patch Set 3 : woops. real CR changes #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	chrome/browser/extensions/extension_browser_event_router.cc	View	1	4 chunks	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM http://codereview.chromium.org/149429/diff/1/2 File chrome/browser/extensions/extension_browser_event_router.cc (right): http://codereview.chromium.org/149429/diff/1/2#newcode319 Line 319: } nit: trailing space

11 years, 5 months ago (2009-07-10 05:49:45 UTC) #2

rafaelw

11 years, 5 months ago (2009-07-10 18:11:56 UTC) #3

http://codereview.chromium.org/149429/diff/1/2
File chrome/browser/extensions/extension_browser_event_router.cc (right):

http://codereview.chromium.org/149429/diff/1/2#newcode319
Line 319: }
On 2009/07/10 05:49:45, pfeldman wrote:
> nit: trailing space

Done.

Expand Messages | Collapse Messages