Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 149426: Fix a few issues with the drop arrow in the Linux tab strip:... (Closed)

Created:
11 years, 5 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Fix a few issues with the drop arrow in the Linux tab strip: * Reset the drop info when completing a drag (successful or otherwise). * Reset the drop info when the drag leaves the tab strip zone. * Report success or failure of the drop back to the source widget. * Move and resize the drop arrow container before showing it to reduce visual jank. BUG=none TEST=Drag a image into the tab strip so that the drop arrow appears. Release the drop over the tab strip and then move the window and repeat the process. The drop arrow should be in the correct position. Notice that there is no visual jank when the drop arrow is shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20404

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 5 chunks +16 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
11 years, 5 months ago (2009-07-09 23:03:24 UTC) #1
James Hawkins
11 years, 5 months ago (2009-07-10 00:23:27 UTC) #2
tony
11 years, 5 months ago (2009-07-10 00:49:09 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698