Issue 149362: Get the Mac build compiling while we figure out how SetActiveUrl should be im...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149362: Get the Mac build compiling while we figure out how SetActiveUrl should be im... (Closed)

Created:
11 years, 5 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get the Mac build compiling while we figure out how SetActiveUrl should be implemented on Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20198

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/child_process_logging_mac.mm	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

On 2009/07/08 22:50:53, John Abd-El-Malek wrote: > LGTM but please add comments explaining our IRC ...

11 years, 5 months ago (2009-07-08 22:54:45 UTC) #2

Scott Hess - ex-Googler

11 years, 5 months ago (2009-07-08 22:57:03 UTC) #3

On 2009/07/08 22:54:45, John Grabowski wrote:
> On 2009/07/08 22:50:53, John Abd-El-Malek wrote:
> > 
> 
> LGTM but please add comments explaining our IRC conversation in the code.

And/or maybe a bug to reference.

Expand Messages | Collapse Messages