Wrote gmock-based mock filters and a mock filter factory.

Wrote gmock-based mock filters and a mock filter factory.

Next up is actually refactoring tests to use these and not the old_mocks version.  The biggest user is the PipelineImpl tests, which I'm currently refactoring anyway hence sending this out for review.

BUG=16008
TEST=FFmpegVideoDecoderTest should still pass

[scherkus (not reviewing), 2009-07-08 22:01:16]

More gmock goodness

[awong, 2009-07-08 22:06:02]

LGTM

http://codereview.chromium.org/149356/diff/1/3
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149356/diff/1/3#newcode168
Line 168: class MockFilterFactory : public FilterFactory {
Hmm...having a factory that holds mocks...this feels a bit heavy weight, but I
guess we have to do it because we use factories to inject our objects?

[scherkus (not reviewing), 2009-07-08 22:14:51]

http://codereview.chromium.org/149356/diff/1/3
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149356/diff/1/3#newcode168
Line 168: class MockFilterFactory : public FilterFactory {
On 2009/07/08 22:06:03, awong wrote:
> Hmm...having a factory that holds mocks...this feels a bit heavy weight, but I
> guess we have to do it because we use factories to inject our objects?

You got it.  Normal filter pattern is to have the constructor private/protected
and only permit a factory to create a filter.  We then pass the factories into
the pipeline who instantiates them via factory.

I'm really not liking the whole system TBH, but this lets us get to writing test
code faster instead of removing the entire factory system -- which isn't
terribly broken, just kludgy

[Alpha Left Google, 2009-07-08 22:15:05]

LGTM except for one minor doubt about making dtor of MockFFmpegDemuxerStream
private.

http://codereview.chromium.org/149356/diff/1/4
File media/filters/ffmpeg_video_decoder_unittest.cc (right):

http://codereview.chromium.org/149356/diff/1/4#newcode36
Line 36: virtual ~MockFFmpegDemuxerStream() {}
you need to make scoped_refptr a friend in order for the dtor to be accessed?

[scherkus (not reviewing), 2009-07-08 22:19:07]

On 2009/07/08 22:15:05, Alpha wrote:
> LGTM except for one minor doubt about making dtor of MockFFmpegDemuxerStream
> private.
> 
> http://codereview.chromium.org/149356/diff/1/4
> File media/filters/ffmpeg_video_decoder_unittest.cc (right):
> 
> http://codereview.chromium.org/149356/diff/1/4#newcode36
> Line 36: virtual ~MockFFmpegDemuxerStream() {}
> you need to make scoped_refptr a friend in order for the dtor to be accessed?

I'm not sure why it doesn't break, but I think having the friend declared in the
base class makes everything work.