Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 149350: Added new gmock-based MockFilterHost and deprecated the old one. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Added new gmock-based MockFilterHost and deprecated the old one. Updated FileDataSource tests to use the new MockFilterHost as a proof of concept, also because my pipeline refactoring completely broke the test. BUG=16008 TEST=FileDataSourceTest.* should pass

Patch Set 1 #

Patch Set 2 : CL is based on 149215 #

Total comments: 3

Patch Set 3 : Remove anon namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -65 lines) Patch
M media/base/mock_filter_host.h View 1 3 chunks +32 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/file_data_source.h View 3 chunks +9 lines, -5 lines 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 2 3 chunks +19 lines, -50 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scherkus (not reviewing)
More gmock goodness
11 years, 5 months ago (2009-07-08 23:03:47 UTC) #1
awong
LGTM http://codereview.chromium.org/149350/diff/1001/31 File media/filters/file_data_source.h (right): http://codereview.chromium.org/149350/diff/1001/31#newcode41 Line 41: // of my tests!!! Ha ha ha...come ...
11 years, 5 months ago (2009-07-08 23:06:53 UTC) #2
Alpha Left Google
LGTM except for the use of namespace in file_data_source_unittest.cc http://codereview.chromium.org/149350/diff/1001/32 File media/filters/file_data_source_unittest.cc (right): http://codereview.chromium.org/149350/diff/1001/32#newcode18 Line ...
11 years, 5 months ago (2009-07-08 23:20:46 UTC) #3
awong
http://codereview.chromium.org/149350/diff/1001/32 File media/filters/file_data_source_unittest.cc (right): http://codereview.chromium.org/149350/diff/1001/32#newcode18 Line 18: namespace { On 2009/07/08 23:20:47, Alpha wrote: > ...
11 years, 5 months ago (2009-07-08 23:23:28 UTC) #4
scherkus (not reviewing)
11 years, 5 months ago (2009-07-09 00:03:29 UTC) #5
removed anon namespace

Powered by Google App Engine
This is Rietveld 408576698