Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: chrome/browser/browser_main.cc

Issue 149348: Linux: Add First Run UI. (Closed)
Patch Set: merge to tot Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/first_run_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_main.cc
diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc
index a6df83486e893693d0a5e21ef95a928141e9a486..403efc921bae4b356bfd21abeeb112f035248100 100644
--- a/chrome/browser/browser_main.cc
+++ b/chrome/browser/browser_main.cc
@@ -386,30 +386,6 @@ int BrowserMain(const MainFunctionParams& parameters) {
#endif
-#if defined(OS_POSIX)
- // On Mac OS X / Linux we display the first run dialog as early as possible,
- // so we can get the stats enabled.
- // TODO(port):
- // We check the kNoFirstRun command line switch explicitly here since the
- // early placement of this block happens before that's factored into
- // first_run_ui_bypass, we probably want to move that block up
- // and remove the explicit check from here in the long run.
- if (is_first_run && !first_run_ui_bypass &&
- !parsed_command_line.HasSwitch(switches::kNoFirstRun)) {
- // Dummy value, we don't need the profile for the OS X version of this
- // method at present.
- Profile* profile = NULL;
- OpenFirstRunDialog(profile, &process_singleton);
-
-#if defined(GOOGLE_CHROME_BUILD)
- // If user cancelled the first run dialog box, the first run sentinel file
- // didn't get created and we should exit Chrome.
- if (FirstRun::IsChromeFirstRun())
- return ResultCodes::NORMAL_EXIT;
-#endif
- }
-#endif // OS_POSIX
-
// During first run we read the google_update registry key to find what
// language the user selected when downloading the installer. This
// becomes our default language in the prefs.
@@ -612,12 +588,6 @@ int BrowserMain(const MainFunctionParams& parameters) {
process_singleton.Create();
- // TODO(port): This block of code should probably be used on all platforms!
- // On Mac OS X / Linux we display this dialog before setting the value of
- // kMetricsReportingEnabled, so we display this dialog much earlier.
- // On Windows a download is tagged with stats enabled/disabled so the UI
- // can be displayed later in the startup process.
-#if !defined(OS_POSIX)
// Show the First Run UI if this is the first time Chrome has been run on
// this computer, or we're being compelled to do so by a command line flag.
// Note that this be done _after_ the PrefService is initialized and all
@@ -626,10 +596,10 @@ int BrowserMain(const MainFunctionParams& parameters) {
if (is_first_run && !first_run_ui_bypass) {
if (!OpenFirstRunDialog(profile, &process_singleton)) {
// The user cancelled the first run dialog box, we should exit Chrome.
+
return ResultCodes::NORMAL_EXIT;
}
}
-#endif // OS_POSIX
// Sets things up so that if we crash from this point on, a dialog will
// popup asking the user to restart chrome. It is done this late to avoid
« no previous file with comments | « no previous file | chrome/browser/first_run_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698