http://codereview.chromium.org/147084...

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
@@ skipping 148 matching lines @@
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <objbase.h>
 #endif
 
 #include "base/file_path.h"
 #include "base/histogram.h"
 #include "base/path_service.h"
 #include "base/platform_thread.h"
+#include "base/rand_util.h"
 #include "base/string_util.h"
 #include "base/task.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/load_notification_details.h"
 #include "chrome/browser/memory_details.h"
 #include "chrome/browser/plugin_service.h"
 #include "chrome/browser/profile.h"
@@ skipping 576 matching lines @@
   GUID guid;
   HRESULT guid_result = CoCreateGuid(&guid);
   DCHECK(SUCCEEDED(guid_result));
 
   std::wstring guid_string;
   int result = StringFromGUID2(guid,
                                WriteInto(&guid_string, kGUIDSize), kGUIDSize);
   DCHECK(result == kGUIDSize);
 
   return WideToUTF8(guid_string.substr(1, guid_string.length() - 2));
+#elif defined(LINUX2)
+  uint64 sixteen_bytes[2] = { base::RandUint64(), base::RandUint64() };
+  return RandomBytesToGUIDString(sixteen_bytes);
 #else
-  // TODO(port): Implement for Mac and linux.
-  // Rather than actually implementing a random source, might this be a good
-  // time to implement http://code.google.com/p/chromium/issues/detail?id=2278
-  // ?  I think so!
+  // TODO(cmasone): enable the above for all OS_POSIX platforms once the
+  // first-run dialog text is all up to date.
   NOTIMPLEMENTED();
   return std::string();
 #endif
 }
 
+#if defined(OS_POSIX)
+// TODO(cmasone): Once we're comfortable this works, migrate Windows code to
+// use this as well.
+std::string MetricsService::RandomBytesToGUIDString(const uint64 bytes[2]) {
+  return StringPrintf("%08llX-%04llX-%04llX-%04llX-%012llX",
+                      bytes[0] >> 32,
+                      (bytes[0] >> 16) & 0x0000ffff,
+                      bytes[0] & 0x0000ffff,
+                      bytes[1] >> 48,
+                      bytes[1] & 0x0000ffffffffffffULL);
+}
+#endif
 
 //------------------------------------------------------------------------------
 // State save methods
 
 void MetricsService::ScheduleNextStateSave() {
   state_saver_factory_.RevokeAll();
 
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
       state_saver_factory_.NewRunnableMethod(&MetricsService::SaveLocalState),
       kSaveStateInterval * 1000);
@@ skipping 1122 matching lines @@
       L"." + key;
   prof_prefs->SetInteger(pref_key.c_str(), value);
 }
 
 static bool IsSingleThreaded() {
   static PlatformThreadId thread_id = 0;
   if (!thread_id)
     thread_id = PlatformThread::CurrentId();
   return PlatformThread::CurrentId() == thread_id;
 }