Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 149343: http://codereview.chromium.org/147084... (Closed)

Created:
11 years, 5 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

http://codereview.chromium.org/147084 Implements unique client ID generation for Posix. Client ID generation happens once-per-install of Chromium (...well, this is mostly true, at least). On Windows, the code currently uses some system library code that generates a GUID. We don't ACTUALLY need a GUID, something that's quite random and in the same format will work. Since we don't want to add a dependency on libuuid for POSIX, I created a less-random-but-still-good-enough version. BUG=15418 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20184

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M chrome/browser/metrics/metrics_service.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 2 chunks +18 lines, -4 lines 0 comments Download
A chrome/browser/metrics/metrics_service_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698