Issue 149342: Make converting from NativeViewId to NativeView an error on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149342: Make converting from NativeViewId to NativeView an error on Mac. (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit), Amanda Walker

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make converting from NativeViewId to NativeView an error on Mac. Goal is to prevent someone from checking in new cross-platform code relying on this.

Patch Set 2 : Typo. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	base/gfx/native_widget_types.h	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/149342/diff/1/2 File base/gfx/native_widget_types.h (right): http://codereview.chromium.org/149342/diff/1/2#newcode103 Line 103: #define NativeViewFromId(x) NATIVE_VIEW_FROM_ID_NOT_AVAILIBLE_ON_MAC Drive by nit: AVAILABLE

11 years, 5 months ago (2009-07-08 21:41:38 UTC) #2

Scott Hess - ex-Googler

11 years, 5 months ago (2009-07-08 21:47:59 UTC) #4