Issue 149329: DevTools: handle call frames with unresolved script sources upon exception br...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149329: DevTools: handle call frames with unresolved script sources upon exception br... (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: handle call frames with unresolved script sources upon exception break. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20147

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	webkit/glue/devtools/js/debugger_agent.js	View		4 chunks	+14 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM http://codereview.chromium.org/149329/diff/1/2 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/149329/diff/1/2#newcode1014 Line 1014: this.unresolved = opt_unresolved; please make it private ...

11 years, 5 months ago (2009-07-08 15:27:45 UTC) #2

pfeldman

11 years, 5 months ago (2009-07-08 15:31:52 UTC) #3

http://codereview.chromium.org/149329/diff/1/2
File webkit/glue/devtools/js/debugger_agent.js (right):

http://codereview.chromium.org/149329/diff/1/2#newcode1014
Line 1014: this.unresolved = opt_unresolved;
On 2009/07/08 15:27:46, Yury Semikhatsky wrote:
> please make it private and define getter

Done.

Expand Messages | Collapse Messages