Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: src/ic.cc

Issue 149326: Process correctly stepping into function calls (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 if (opt->IsJSFunction()) return opt; 390 if (opt->IsJSFunction()) return opt;
391 } 391 }
392 392
393 #ifdef ENABLE_DEBUGGER_SUPPORT 393 #ifdef ENABLE_DEBUGGER_SUPPORT
394 // Handle stepping into a function if step into is active. 394 // Handle stepping into a function if step into is active.
395 if (Debug::StepInActive()) { 395 if (Debug::StepInActive()) {
396 // Protect the result in a handle as the debugger can allocate and might 396 // Protect the result in a handle as the debugger can allocate and might
397 // cause GC. 397 // cause GC.
398 HandleScope scope; 398 HandleScope scope;
399 Handle<JSFunction> function(JSFunction::cast(result)); 399 Handle<JSFunction> function(JSFunction::cast(result));
400 Debug::HandleStepIn(function, fp(), false); 400 Debug::HandleStepIn(function, object, fp(), false);
401 return *function; 401 return *function;
402 } 402 }
403 #endif 403 #endif
404 404
405 return result; 405 return result;
406 } 406 }
407 407
408 // Try to find a suitable function delegate for the object at hand. 408 // Try to find a suitable function delegate for the object at hand.
409 result = TryCallAsFunction(result); 409 result = TryCallAsFunction(result);
410 return result->IsJSFunction() ? 410 return result->IsJSFunction() ?
(...skipping 945 matching lines...) Expand 10 before | Expand all | Expand 10 after
1356 #undef ADDR 1356 #undef ADDR
1357 }; 1357 };
1358 1358
1359 1359
1360 Address IC::AddressFromUtilityId(IC::UtilityId id) { 1360 Address IC::AddressFromUtilityId(IC::UtilityId id) {
1361 return IC_utilities[id]; 1361 return IC_utilities[id];
1362 } 1362 }
1363 1363
1364 1364
1365 } } // namespace v8::internal 1365 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698