chrome/browser/cocoa/browser_window_impl.h - Issue 149325: Add facitility for Global Keyboard shortcuts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/cocoa/browser_window_impl.h

Issue 149325: Add facitility for Global Keyboard shortcuts. (Closed)

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_COCOA_BROWSER_WINDOW_IMPL_H_

	6 #define CHROME_BROWSER_COCOA_BROWSER_WINDOW_IMPL_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 // Cocoa class representing a Chrome browser window.
	pink (ping after 24hrs) 2009/07/08 13:48:17 state why we are overriding NSWindow. For what pur state why we are overriding NSWindow. For what purpose? Why does this class need to exist?
	11 @interface ChromeBrowserWindowImpl : NSWindow
	pink (ping after 24hrs) 2009/07/08 13:48:17 isn't calling it an "impl" redundant? In fact, thi isn't calling it an "impl" redundant? In fact, this is an interface, not an implementation, but of course it has an implementation. You can't have one w/out the other. I'd say drop the "impl" part.
	12

	13 // Override, so we can handle global keyboard events.

	14 - (BOOL)performKeyEquivalent:(NSEvent *)theEvent;

	15 @end

	16

	17 #endif // CHROME_BROWSER_COCOA_BROWSER_WINDOW_IMPL_H_

OLD	NEW