Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/objects.cc

Issue 149316: Fix issue with skipping global object during lookup through... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
===================================================================
--- src/objects.cc (revision 2384)
+++ src/objects.cc (working copy)
@@ -1711,6 +1711,10 @@
if (IsGlobalObject()) {
PropertyDetails d = property_dictionary()->DetailsAt(entry);
if (d.IsDeleted()) {
+ // We've skipped a global object during lookup, so we cannot
+ // use inline caching because the map of the global object
+ // doesn't change if the property should be re-added.
+ result->DisallowCaching();
result->NotFound();
return;
}
« no previous file with comments | « no previous file | test/mjsunit/global-deleted-property-ic.js » ('j') | test/mjsunit/global-deleted-property-ic.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698