Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 149316: Fix issue with skipping global object during lookup through... (Closed)

Created:
11 years, 5 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
bak
CC:
v8-dev
Visibility:
Public.

Description

Fix issue with skipping global object during lookup through the prototype chain. In case we're skipping a global object, we have to be careful not to use ICs for the load, because it's possible to introduce variables on the global object without a map change. Committed: http://code.google.com/p/v8/source/detail?r=2385

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/global-deleted-property-ic.js View 1 chunk +53 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years, 5 months ago (2009-07-08 06:13:37 UTC) #1
bak
11 years, 5 months ago (2009-07-08 07:09:50 UTC) #2
LGTM,
  Lars

http://codereview.chromium.org/149316/diff/1/2
File test/mjsunit/global-deleted-property-ic.js (right):

http://codereview.chromium.org/149316/diff/1/2#newcode32
Line 32: assertEquals(42, LoadX(this));
How about:
   for(var i = 0; i < 3; i++) assertEquals(....)

Powered by Google App Engine
This is Rietveld 408576698