Issue 149313: Fix memory leak in ImageButton exposed by r20028.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149313: Fix memory leak in ImageButton exposed by r20028. (Closed)

Created:
11 years, 5 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix memory leak in ImageButton exposed by r20028. BUG= none. TEST= none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20134

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	views/controls/button/image_button.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	views/controls/button/image_button.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Miranda Callahan

Put background_image_ in a scoped_ptr so that memory doesn't leak.

11 years, 5 months ago (2009-07-08 06:57:11 UTC) #1

LG