Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 149306: Disk cache: Add explicit support for eviction / deletion... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Disk cache: Add explicit support for eviction / deletion of sparse entries. I started to add code to modify the children_map of the parent entry when a child is evicted but that ended up being too much trouble for too little gain. We have to be prepared to handle the case of not finding a child entry because there is no way to make sure that the process doesn't go away at any time, so adding a lot of complexity just to avoid an extra entry lookup is just not worth it. On the other hand, potentially freeing up a lot of space when a sparse entry is deleted (insetad of just waiting for the eviction code to do the cleanup) seems like a good thing. BUG=12258 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -13 lines) Patch
M net/disk_cache/block_files.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/disk_cache/disk_format.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/disk_cache/entry_impl.h View 1 chunk +16 lines, -0 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 3 chunks +58 lines, -1 line 0 comments Download
M net/disk_cache/sparse_control.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 8 chunks +153 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
11 years, 5 months ago (2009-07-08 01:28:38 UTC) #1
Nicolas Sylvain
lgtm
11 years, 5 months ago (2009-07-08 23:24:02 UTC) #2
Alpha Left Google
11 years, 5 months ago (2009-07-09 21:07:47 UTC) #3
Sorry for the delay. LGTM.

Powered by Google App Engine
This is Rietveld 408576698