Issue 149301: Gtk: URI list dragging for bookmarks (source side only)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149301: Gtk: URI list dragging for bookmarks (source side only)... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Gtk: URI list dragging for bookmarks (source side only) BUG=none TEST=drag a bookmark into the webview or onto another program such as konqueror. The right thing should happen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20107

Patch Set 1 #

Total comments: 1

Patch Set 2 : undo accidental change #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -4 lines)			Patch
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_utils_gtk.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_dnd_util.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

LGTM. Suggestion: http://codereview.chromium.org/149301/diff/1/5 File chrome/browser/gtk/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/149301/diff/1/5#newcode406 Line 406: GtkDndUtil::X_CHROME_TEXT_URI_LIST); You may want to rename ...

11 years, 5 months ago (2009-07-08 00:34:22 UTC) #2

Evan Stade

11 years, 5 months ago (2009-07-08 00:35:59 UTC) #3

you're right; I'll do that in a separate pass since it touches a bunch of files.

Expand Messages | Collapse Messages