Issue 149296: Make the cancelling of drag and drop match Safari for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149296: Make the cancelling of drag and drop match Safari for Windows. (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make the cancelling of drag and drop match Safari for Windows. This is a follow up CL to http://codereview.chromium.org/149038 as well as to https://bugs.webkit.org/show_bug.cgi?id=26699 With this change we use DragOperationNone (instead of DragOperationCopy) and NoButton (instead of LeftButton) when the user presses Escape. BUG=12018 TEST=On the new new tab page drag one of the thumbnails out of the window and press escape. The thumbnail should move back to its starting position. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20125

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -12 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	webkit/glue/webview.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View		1 chunk	+11 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM! Thanks for doing this.