Issue 149292: Make font fallback case insensitive....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149292: Make font fallback case insensitive.... (Closed)

Created:
11 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make font fallback case insensitive. BUG=16047 TEST=Go to a site that has css with font-family: sans on Debian Lenny. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20123

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	skia/ext/SkFontHost_fontconfig_direct.cpp	View		1 chunk	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

It's also possible to fix bug 16047 in chromium/FontCacheLinux.cpp, but fixing it in Skia is ...

11 years, 5 months ago (2009-07-07 23:13:55 UTC) #1

agl

NACK. http://codereview.chromium.org/149292/diff/1/2 File skia/ext/SkFontHost_fontconfig_direct.cpp (right): http://codereview.chromium.org/149292/diff/1/2#newcode38 Line 38: const char* family_cstr = family.c_str(); NACK. These ...

11 years, 5 months ago (2009-07-08 01:17:28 UTC) #2

Lei Zhang

11 years, 5 months ago (2009-07-08 01:39:21 UTC) #3

platform/graphics/FontCache.cpp seems to treat them as case insensitive. I.e.
"Sans" + foo {size,bold,italic} settings and "sans" + foo {size,bold,italic}
settings get the same hash.

Thus if a webpage requests "sans", the normal lookup code will fail and put NULL
in the cache. Then we do a fallback, and the fallback goes to "Sans", but we
just end up looking in the cache in the "sans" bucket, fetch the NULL, and blow
up.

Expand Messages | Collapse Messages