Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 149291: Add some logging to a flakey browsertest to debug. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browsertests_misc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index 3dcef8be6b212159ac7492ca7b590bea81ddf913..72ac2cdf8d6df09706d9ba74849d5e2c9935fb00 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -68,8 +68,14 @@ bool ExtensionBrowserTest::InstallExtension(const FilePath& path) {
registrar_.Remove(this, NotificationType::EXTENSION_INSTALLED,
NotificationService::AllSources());
size_t num_after = service->extensions()->size();
- if (num_after != (num_before + 1))
+ if (num_after != (num_before + 1)) {
+ std::cout << "Num extensions before: " << IntToString(num_before)
+ << "num after: " << IntToString(num_after)
+ << "Installed extensions are:\n";
+ for (size_t i = 0; i < service->extensions()->size(); ++i)
+ std::cout << " " << service->extensions()->at(i)->id() << "\n";
return false;
+ }
return WaitForExtensionHostsToLoad();
}
@@ -89,8 +95,11 @@ bool ExtensionBrowserTest::WaitForExtensionHostsToLoad() {
for (ExtensionProcessManager::const_iterator iter = manager->begin();
iter != manager->end(); ++iter) {
while (!(*iter)->did_stop_loading()) {
- if ((base::Time::Now() - start_time).InMilliseconds() > kTimeoutMs)
+ if ((base::Time::Now() - start_time).InMilliseconds() > kTimeoutMs) {
+ std::cout << "Extension host did not load for URL: "
+ << (*iter)->GetURL().spec();
return false;
+ }
MessageLoop::current()->PostDelayedTask(FROM_HERE,
new MessageLoop::QuitTask, 200);
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browsertests_misc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698