Fix the unit tests that had multiple ResourceDispatcherHost objects instantia...

chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/message_loop.h"
 #include "base/process_util.h"
 #include "chrome/browser/child_process_security_policy.h"
@@ skipping 236 matching lines @@
   ASSERT_EQ(3U, msgs.size());
 
   CheckSuccessfulRequest(msgs[0], URLRequestTestJob::test_data_1());
   CheckSuccessfulRequest(msgs[1], URLRequestTestJob::test_data_2());
   CheckSuccessfulRequest(msgs[2], URLRequestTestJob::test_data_3());
 }
 
 // Tests whether messages get canceled properly. We issue three requests,
 // cancel one of them, and make sure that each sent the proper notifications.
 TEST_F(ResourceDispatcherHostTest, Cancel) {
-  ResourceDispatcherHost host(NULL);
-
   EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(0));
 
   MakeTestRequest(0, 0, 1, URLRequestTestJob::test_url_1());
   MakeTestRequest(0, 0, 2, URLRequestTestJob::test_url_2());
   MakeTestRequest(0, 0, 3, URLRequestTestJob::test_url_3());
   MakeCancelRequest(2);
 
   // flush all the pending requests
   while (URLRequestTestJob::ProcessOnePendingMessage());
   MessageLoop::current()->RunAllPending();
@@ skipping 266 matching lines @@
   // Since the upload throttling is disabled, this has no effect on the cost.
   EXPECT_EQ(4434, ResourceDispatcherHost::CalculateApproximateMemoryCost(&req));
 
   // Add a file upload -- should have no effect.
   req.AppendFileToUpload(FilePath(FILE_PATH_LITERAL("does-not-exist.png")));
   EXPECT_EQ(4434, ResourceDispatcherHost::CalculateApproximateMemoryCost(&req));
 }
 
 // Test the private helper method "IncrementOutstandingRequestsMemoryCost()".
 TEST_F(ResourceDispatcherHostTest, IncrementOutstandingRequestsMemoryCost) {
-  ResourceDispatcherHost host(NULL);
-
   // Add some counts for render_process_host=7
-  EXPECT_EQ(0, host.GetOutstandingRequestsMemoryCost(7));
-  EXPECT_EQ(1, host.IncrementOutstandingRequestsMemoryCost(1, 7));
-  EXPECT_EQ(2, host.IncrementOutstandingRequestsMemoryCost(1, 7));
-  EXPECT_EQ(3, host.IncrementOutstandingRequestsMemoryCost(1, 7));
+  EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(7));
+  EXPECT_EQ(1, host_.IncrementOutstandingRequestsMemoryCost(1, 7));
+  EXPECT_EQ(2, host_.IncrementOutstandingRequestsMemoryCost(1, 7));
+  EXPECT_EQ(3, host_.IncrementOutstandingRequestsMemoryCost(1, 7));
 
   // Add some counts for render_process_host=3
-  EXPECT_EQ(0, host.GetOutstandingRequestsMemoryCost(3));
-  EXPECT_EQ(1, host.IncrementOutstandingRequestsMemoryCost(1, 3));
-  EXPECT_EQ(2, host.IncrementOutstandingRequestsMemoryCost(1, 3));
+  EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(3));
+  EXPECT_EQ(1, host_.IncrementOutstandingRequestsMemoryCost(1, 3));
+  EXPECT_EQ(2, host_.IncrementOutstandingRequestsMemoryCost(1, 3));
 
   // Remove all the counts for render_process_host=7
-  EXPECT_EQ(3, host.GetOutstandingRequestsMemoryCost(7));
-  EXPECT_EQ(2, host.IncrementOutstandingRequestsMemoryCost(-1, 7));
-  EXPECT_EQ(1, host.IncrementOutstandingRequestsMemoryCost(-1, 7));
-  EXPECT_EQ(0, host.IncrementOutstandingRequestsMemoryCost(-1, 7));
-  EXPECT_EQ(0, host.GetOutstandingRequestsMemoryCost(7));
+  EXPECT_EQ(3, host_.GetOutstandingRequestsMemoryCost(7));
+  EXPECT_EQ(2, host_.IncrementOutstandingRequestsMemoryCost(-1, 7));
+  EXPECT_EQ(1, host_.IncrementOutstandingRequestsMemoryCost(-1, 7));
+  EXPECT_EQ(0, host_.IncrementOutstandingRequestsMemoryCost(-1, 7));
+  EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(7));
 
   // Remove all the counts for render_process_host=3
-  EXPECT_EQ(2, host.GetOutstandingRequestsMemoryCost(3));
-  EXPECT_EQ(1, host.IncrementOutstandingRequestsMemoryCost(-1, 3));
-  EXPECT_EQ(0, host.IncrementOutstandingRequestsMemoryCost(-1, 3));
-  EXPECT_EQ(0, host.GetOutstandingRequestsMemoryCost(3));
+  EXPECT_EQ(2, host_.GetOutstandingRequestsMemoryCost(3));
+  EXPECT_EQ(1, host_.IncrementOutstandingRequestsMemoryCost(-1, 3));
+  EXPECT_EQ(0, host_.IncrementOutstandingRequestsMemoryCost(-1, 3));
+  EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(3));
 
   // When an entry reaches 0, it should be deleted.
-  EXPECT_TRUE(host.outstanding_requests_memory_cost_map_.end() ==
-      host.outstanding_requests_memory_cost_map_.find(7));
-  EXPECT_TRUE(host.outstanding_requests_memory_cost_map_.end() ==
-      host.outstanding_requests_memory_cost_map_.find(3));
+  EXPECT_TRUE(host_.outstanding_requests_memory_cost_map_.end() ==
+      host_.outstanding_requests_memory_cost_map_.find(7));
+  EXPECT_TRUE(host_.outstanding_requests_memory_cost_map_.end() ==
+      host_.outstanding_requests_memory_cost_map_.find(3));
 }
 
 // Test that when too many requests are outstanding for a particular
 // render_process_host_id, any subsequent request from it fails.
 TEST_F(ResourceDispatcherHostTest, TooManyOutstandingRequests) {
   EXPECT_EQ(0, host_.GetOutstandingRequestsMemoryCost(0));
 
   // Expected cost of each request as measured by
   // ResourceDispatcherHost::CalculateApproximateMemoryCost().
   int kMemoryCostOfTest2Req =
@@ skipping 60 matching lines @@
     EXPECT_EQ(URLRequestStatus::CANCELED, status.status());
     EXPECT_EQ(net::ERR_INSUFFICIENT_RESOURCES, status.os_error());
   }
 
   // The final 2 requests should have succeeded.
   CheckSuccessfulRequest(msgs[kMaxRequests + 2],
                          URLRequestTestJob::test_data_2());
   CheckSuccessfulRequest(msgs[kMaxRequests + 3],
                          URLRequestTestJob::test_data_2());
 }