Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: chrome/browser/download/save_page_uitest.cc

Issue 149281: Sprinkle some defensiveness into the UI tests so that they don't explode if t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_uitest.cc
===================================================================
--- chrome/browser/download/save_page_uitest.cc (revision 19956)
+++ chrome/browser/download/save_page_uitest.cc (working copy)
@@ -98,6 +98,7 @@
GURL url = URLRequestMockHTTPJob::GetMockUrl(
UTF8ToWide(std::string(kTestDir) + "/" + file_name));
scoped_refptr<TabProxy> tab(GetActiveTab());
+ ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(url));
WaitUntilTabCount(1);
@@ -120,6 +121,7 @@
GURL url = URLRequestMockHTTPJob::GetMockUrl(
UTF8ToWide(std::string(kTestDir) + "/" + file_name));
scoped_refptr<TabProxy> tab(GetActiveTab());
+ ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(url));
WaitUntilTabCount(1);
@@ -143,6 +145,7 @@
FilePath dir = save_dir_.AppendASCII("c_files");
scoped_refptr<TabProxy> tab(GetActiveTab());
+ ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(GURL("about:blank")));
WaitUntilTabCount(1);
@@ -164,6 +167,7 @@
GURL url = URLRequestMockHTTPJob::GetMockUrl(
UTF8ToWide(std::string(kTestDir) + "/" + file_name));
scoped_refptr<TabProxy> tab(GetActiveTab());
+ ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(url));
WaitUntilTabCount(1);
@@ -196,6 +200,7 @@
GURL url = URLRequestMockHTTPJob::GetMockUrl(
UTF8ToWide(std::string(kTestDir) + "/" + file_name));
scoped_refptr<TabProxy> tab(GetActiveTab());
+ ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(url));
WaitUntilTabCount(1);
« no previous file with comments | « chrome/browser/download/download_uitest.cc ('k') | chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698