Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/automated_ui_tests/automated_ui_test_base.cc

Issue 149281: Sprinkle some defensiveness into the UI tests so that they don't explode if t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/find_bar_win_uitest.cc ('k') | chrome/test/automated_ui_tests/automated_ui_test_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automated_ui_tests/automated_ui_test_base.cc
===================================================================
--- chrome/test/automated_ui_tests/automated_ui_test_base.cc (revision 19956)
+++ chrome/test/automated_ui_tests/automated_ui_test_base.cc (working copy)
@@ -253,7 +253,10 @@
return false;
}
int num_browser_windows;
- automation()->GetBrowserWindowCount(&num_browser_windows);
+ if (!automation()->GetBrowserWindowCount(&num_browser_windows)) {
+ LogErrorMessage("failed_to_get_browser_window_count");
+ return false;
+ }
// Get the most recently opened browser window and activate the tab
// in order to activate this browser window.
scoped_refptr<BrowserProxy> browser(
« no previous file with comments | « chrome/browser/views/find_bar_win_uitest.cc ('k') | chrome/test/automated_ui_tests/automated_ui_test_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698