Sprinkle some defensiveness into the UI tests so that they don't explode if t...

chrome/worker/worker_uitest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/browser/worker_host/worker_service.h"
 #include "chrome/common/chrome_paths.h"
@@ skipping 51 matching lines @@
     : UITest(), initialized_for_layout_test_(false), test_count_(0) {
 }
 
 WorkerTest::~WorkerTest() {
   if (!temp_test_dir_.empty())
     file_util::Delete(temp_test_dir_, true);
 }
 
 void WorkerTest::RunTest(const std::wstring& test_case) {
   scoped_refptr<TabProxy> tab(GetActiveTab());
+  ASSERT_TRUE(tab.get());
 
   GURL url = GetTestUrl(L"workers", test_case);
   ASSERT_TRUE(tab->NavigateToURL(url));
 
   std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
       kTestCompleteCookie, kTestIntervalMs, kTestWaitTimeoutMs);
   ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
 }
 
 void WorkerTest::InitializeForLayoutTest(const FilePath& test_parent_dir,
@@ skipping 117 matching lines @@
     new_test_url.reset(new GURL(
         std::string("http://localhost:8080/") +
         UTF16ToUTF8(test_case_dir_.ToWStringHack()) +
         "/" +
         test_case_file_name));
   else
     new_test_url.reset(new GURL(net::FilePathToFileURL(new_test_file_path)));
 
   // Runs the new layout test.
   scoped_refptr<TabProxy> tab(GetActiveTab());
+  ASSERT_TRUE(tab.get());
   ASSERT_TRUE(tab->NavigateToURL(*new_test_url.get()));
   std::string escaped_value =
       WaitUntilCookieNonEmpty(tab.get(), *new_test_url.get(),
           status_cookie.c_str(), kTestIntervalMs, kTestWaitTimeoutMs);
 
   // Unescapes and normalizes the actual result.
   std::string value = UnescapeURLComponent(escaped_value,
       UnescapeRule::NORMAL | UnescapeRule::SPACES |
           UnescapeRule::URL_SPECIAL_CHARS | UnescapeRule::CONTROL_CHARS);
   value += "\n";
@@ skipping 113 matching lines @@
     RunLayoutTest(kLayoutTestFiles[i], true);
   StopHttpServer();
 }
 
 TEST_F(WorkerTest, LimitPerPage) {
   int max_workers_per_tab = WorkerService::kMaxWorkersPerTabWhenSeparate;
   GURL url = GetTestUrl(L"workers", L"many_workers.html");
   url = GURL(url.spec() + StringPrintf("?count=%d", max_workers_per_tab + 1));
 
   scoped_refptr<TabProxy> tab(GetActiveTab());
+  ASSERT_TRUE(tab.get());
   ASSERT_TRUE(tab->NavigateToURL(url));
 
   EXPECT_EQ(max_workers_per_tab + 1 + (UITest::in_process_renderer() ? 0 : 1),
             UITest::GetBrowserProcessCount());
 }
 
 TEST_F(WorkerTest, LimitTotal) {
   int max_workers_per_tab = WorkerService::kMaxWorkersPerTabWhenSeparate;
   int total_workers = WorkerService::kMaxWorkersWhenSeparate;
 
   int tab_count = (total_workers / max_workers_per_tab) + 1;
   GURL url = GetTestUrl(L"workers", L"many_workers.html");
   url = GURL(url.spec() + StringPrintf("?count=%d", max_workers_per_tab));
 
   scoped_refptr<TabProxy> tab(GetActiveTab());
+  ASSERT_TRUE(tab.get());
   ASSERT_TRUE(tab->NavigateToURL(url));
   scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
   for (int i = 1; i < tab_count; ++i)
     window->AppendTab(url);
 
   // Check that we didn't create more than the max number of workers.
   EXPECT_EQ(total_workers + 1 + (UITest::in_process_renderer() ? 0 : tab_count),
             UITest::GetBrowserProcessCount());
 
   // Now close the first tab and check that the queued workers were started.
   tab->Close(true);
   tab->NavigateToURL(GetTestUrl(L"google", L"google.html"));
 
   EXPECT_EQ(total_workers + 1 + (UITest::in_process_renderer() ? 0 : tab_count),
             UITest::GetBrowserProcessCount());
 }