Sprinkle some defensiveness into the UI tests so that they don't explode if t...

chrome/browser/download/download_uitest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 #include <string>
 
 #include "build/build_config.h"
 #if defined(OS_WIN)
 #include <shlwapi.h>
@@ skipping 295 matching lines @@
               L"100% - " + filename.ToWStringHack());
 }
 
 // Test that when downloading an item in Incognito mode, we don't crash when
 // closing the last Incognito window (http://crbug.com/13983).
 TEST_F(DownloadTest, MAYBE_IncognitoDownload) {
   // Open a regular window and sanity check default values for window / tab
   // count and shelf visibility.
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   int window_count = 0;
-  automation()->GetBrowserWindowCount(&window_count);
+  ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
   ASSERT_EQ(1, window_count);
   EXPECT_EQ(1, GetTabCount());
   bool is_shelf_visible;
   browser->IsShelfVisible(&is_shelf_visible);
   EXPECT_FALSE(is_shelf_visible);
 
   // Open an Incognito window.
   ASSERT_TRUE(browser->RunCommand(IDC_NEW_INCOGNITO_WINDOW));
   scoped_refptr<BrowserProxy> incognito(automation()->GetBrowserWindow(1));
   scoped_refptr<TabProxy> tab(incognito->GetTab(0));
-  automation()->GetBrowserWindowCount(&window_count);
+  ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
   ASSERT_EQ(2, window_count);
 
   // Download something.
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   //PlatformThread::Sleep(1000);
   ASSERT_TRUE(tab->NavigateToURL(
       URLRequestMockHTTPJob::GetMockUrl(file.ToWStringHack())));
   PlatformThread::Sleep(action_timeout_ms());
 
   // Verify that the download shelf is showing for the Incognito window.
   EXPECT_TRUE(WaitForDownloadShelfVisible(incognito.get()));
 
   // Close the Incognito window and don't crash.
   ASSERT_TRUE(incognito->RunCommand(IDC_CLOSE_WINDOW));
-  automation()->GetBrowserWindowCount(&window_count);
+  ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
   ASSERT_EQ(1, window_count);
 
   // Verify that the regular window does not have a download shelf.
   browser->IsShelfVisible(&is_shelf_visible);
   EXPECT_FALSE(is_shelf_visible);
 
   CleanUpDownload(file);
 }
 
 }  // namespace