Issue 149277: GTK Themes: Theme the popup notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149277: GTK Themes: Theme the popup notification. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK Themes: Theme the popup notification. TEST=Open popuptest.com in one tab and anything else in another. Switch between GTK theme and normal. Theme of blocked popup container should change, even when not the active tab. http://crbug.com/13967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20085

Patch Set 1 #

Patch Set 2 : lint + comments #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -27 lines)			Patch
M	chrome/browser/blocked_popup_container.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/blocked_popup_container.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/blocked_popup_container_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/blocked_popup_container_view_gtk.h	View		4 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/blocked_popup_container_view_gtk.cc	View	1	5 chunks	+38 lines, -18 lines	1 comment	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	1	6 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 5 months ago (2009-07-07 20:46:28 UTC) #2

LGTM!  I need profile() plumbed through in BlockedPopupContainer for tinted
buttons too.

http://codereview.chromium.org/149277/diff/18/22
File chrome/browser/gtk/blocked_popup_container_view_gtk.cc (right):

http://codereview.chromium.org/149277/diff/18/22#newcode213
Line 213: // TODO(erg): We draw the gradient background only when GTK themes are
I see, so we still draw the background, it's just not a gradient.  That sounds
fine to me.

Expand Messages | Collapse Messages