Issue 149273: Initialize the age field in Linux Breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149273: Initialize the age field in Linux Breakpad. (Closed)

Created:
11 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initialize the age field in Linux Breakpad. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20079

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	breakpad/linux/minidump_writer.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I think this should fix the miss symbols in crash dumps due to garbage value ...

11 years, 5 months ago (2009-07-07 20:13:37 UTC) #1

agl

LGTM http://codereview.chromium.org/149273/diff/1/2 File breakpad/linux/minidump_writer.cc (right): http://codereview.chromium.org/149273/diff/1/2#newcode557 Line 557: *cv_ptr = 0; // Set age to ...

11 years, 5 months ago (2009-07-07 21:05:29 UTC) #2

Lei Zhang

11 years, 5 months ago (2009-07-07 21:09:44 UTC) #3

http://codereview.chromium.org/149273/diff/1/2
File breakpad/linux/minidump_writer.cc (right):

http://codereview.chromium.org/149273/diff/1/2#newcode557
Line 557: *cv_ptr = 0;  // Set age to 0 on Linux.
On 2009/07/07 21:05:29, agl wrote:
> memset(cv_ptr, 0, sizeof(uint32_t))?
> 
> You're setting a single byte, but then skipping four.

Done, with my_memset().

Expand Messages | Collapse Messages