DevTools: test that a breakpoint can be set

DevTools: added test for setting breakpoit.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20135

[pfeldman, 2009-07-07 17:26:10]

http://codereview.chromium.org/149256/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/149256/diff/1/3#newcode158
Line 158: TestSuite.prototype.overrideOnce = function(receiver, methodName,
override) {
could you use this in the other places as well?

http://codereview.chromium.org/149256/diff/1/3#newcode158
Line 158: TestSuite.prototype.overrideOnce = function(receiver, methodName,
override) {
overrideOnce -> addSniffer(receiver, methodName, handler, opt_sticky)

http://codereview.chromium.org/149256/diff/1/3#newcode160
Line 160: debugPrint('overriding ' + orig);
please remove traces.

http://codereview.chromium.org/149256/diff/1/3#newcode425
Line 425: if (!view.sourceFrame._isContentLoaded()) {
let's hardcode whether it is loaded or not.

[yurys, 2009-07-08 06:41:38]

http://codereview.chromium.org/149256/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/149256/diff/1/3#newcode158
Line 158: TestSuite.prototype.overrideOnce = function(receiver, methodName,
override) {
On 2009/07/07 17:26:10, pfeldman wrote:
> overrideOnce -> addSniffer(receiver, methodName, handler, opt_sticky)

Done.

http://codereview.chromium.org/149256/diff/1/3#newcode158
Line 158: TestSuite.prototype.overrideOnce = function(receiver, methodName,
override) {
On 2009/07/07 17:26:10, pfeldman wrote:
> could you use this in the other places as well?

Done.

http://codereview.chromium.org/149256/diff/1/3#newcode160
Line 160: debugPrint('overriding ' + orig);
On 2009/07/07 17:26:10, pfeldman wrote:
> please remove traces.

Done.

http://codereview.chromium.org/149256/diff/1/3#newcode425
Line 425: if (!view.sourceFrame._isContentLoaded()) {
On 2009/07/07 17:26:10, pfeldman wrote:
> let's hardcode whether it is loaded or not.

Done.

[pfeldman, 2009-07-08 07:54:06]

LGTM, thanks for doing this.