Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Side by Side Diff: test/cctest/test-api.cc

Issue 149249: Fix issue number 398: replacing a constant function on a clone. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7023 matching lines...) Expand 10 before | Expand all | Expand 10 after
7034 // See http://crbug.com/12548. 7034 // See http://crbug.com/12548.
7035 THREADED_TEST(InitGlobalVarInProtoChain) { 7035 THREADED_TEST(InitGlobalVarInProtoChain) {
7036 v8::HandleScope scope; 7036 v8::HandleScope scope;
7037 LocalContext context; 7037 LocalContext context;
7038 // Introduce a variable in the prototype chain. 7038 // Introduce a variable in the prototype chain.
7039 CompileRun("__proto__.x = 42"); 7039 CompileRun("__proto__.x = 42");
7040 v8::Handle<v8::Value> result = CompileRun("var x; x"); 7040 v8::Handle<v8::Value> result = CompileRun("var x; x");
7041 CHECK(!result->IsUndefined()); 7041 CHECK(!result->IsUndefined());
7042 CHECK_EQ(42, result->Int32Value()); 7042 CHECK_EQ(42, result->Int32Value());
7043 } 7043 }
7044
7045
7046 // Regression test for issue 398.
7047 // If a function is added to an object, creating a constant function
7048 // field, and the result is cloned, replacing the constant function on the
7049 // original should not affect the clone.
7050 // See http://code.google.com/p/v8/issues/detail?id=398
7051 THREADED_TEST(ReplaceConstantFunction) {
7052 v8::HandleScope scope;
7053 LocalContext context;
7054 v8::Handle<v8::Object> obj = v8::Object::New();
7055 v8::Handle<v8::FunctionTemplate> func_templ = v8::FunctionTemplate::New();
7056 v8::Handle<v8::String> foo_string = v8::String::New("foo");
7057 obj->Set(foo_string, func_templ->GetFunction());
7058 v8::Handle<v8::Object> obj_clone = obj->Clone();
7059 obj_clone->Set(foo_string, v8::String::New("Hello"));
7060 CHECK(!obj->Get(foo_string)->IsUndefined());
7061 }
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698