Issue 149247: Fix issue 397 and issue 399.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149247: Fix issue 397 and issue 399. (Closed)

Created:
11 years, 5 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bak, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix issue 397 and issue 399. Committed: http://code.google.com/p/v8/source/detail?r=2372

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -13 lines)			Patch
M	src/date-delay.js	View	1 2 3	4 chunks	+30 lines, -3 lines	1 comment	Download
M	src/runtime.cc	View		1 chunk	+15 lines, -10 lines	0 comments	Download
A	test/mjsunit/regress/regress-397.js	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-399.js	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

The regression test for 399 is missing. I think we should add one that fails ...

11 years, 5 months ago (2009-07-07 11:23:55 UTC) #2

bak

11 years, 5 months ago (2009-07-07 11:54:02 UTC) #4

LGTM,
  Lars

http://codereview.chromium.org/149247/diff/1006/20
File src/date-delay.js (right):

http://codereview.chromium.org/149247/diff/1006/20#newcode435
Line 435: // Cached year. Only valid when the time matches cached time.
Year when interpreting time as a local time.

Expand Messages | Collapse Messages