Issue 149246: DevTools: Add more sanity tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149246: DevTools: Add more sanity tests. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Add more sanity tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20017

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -36 lines)			Patch
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View		3 chunks	+19 lines, -3 lines	0 comments	Download
A	chrome/test/data/devtools/eval_test_page.html	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/tests.js	View	1	11 chunks	+126 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM http://codereview.chromium.org/149246/diff/1/5 File webkit/glue/devtools/js/tests.js (right): http://codereview.chromium.org/149246/diff/1/5#newcode341 Line 341: return; remove this and other returns following ...

11 years, 5 months ago (2009-07-07 10:46:29 UTC) #2

pfeldman

11 years, 5 months ago (2009-07-07 10:48:21 UTC) #3

LGTM

http://codereview.chromium.org/149246/diff/1/5
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/149246/diff/1/5#newcode341
Line 341: return;
On 2009/07/07 10:46:29, Yury Semikhatsky wrote:
> remove this and other returns following right after test.fail

Done.

http://codereview.chromium.org/149246/diff/1/5#newcode363
Line 363: controller.releaseControl();
On 2009/07/07 10:46:29, Yury Semikhatsky wrote:
> please remove this line

Done.

http://codereview.chromium.org/149246/diff/1/5#newcode378
Line 378: };
On 2009/07/07 10:46:29, Yury Semikhatsky wrote:
> 2 lines between method definitions

Nah

Expand Messages | Collapse Messages

Issue 149246: DevTools: Add more sanity tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages