Issue 149244: Speculative Crash fix: Return early if user cancels save dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149244: Speculative Crash fix: Return early if user cancels save dialog. (Closed)

Created:
11 years, 5 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Visibility:
Public.

Description

Speculative Crash fix: Return early if user cancels save dialog. I'm not able to repro the crash, but this seems safer overall. BUG=16081 TEST=Right click an image, Save as, Chrome should not crash.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
	M	chrome/browser/cocoa/shell_dialogs_mac.mm	View		1 chunk	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG

Expand Messages | Collapse Messages