For linux correctly implementing GetPeerName() to point to TCPClientSocket::G...

Correctly implementing GetPeerName() to point to TCPClientSocket::GetPeerName(). This is used by the SSL layer in Linux to resolve Peer Names, which caused a trap to be generated ( http://crbug/16166 )

BUG=16166
TEST=fix of the above BUG


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20170

[Arindam, 2009-07-07 06:25:26]

Small change for fixing the GetPeerName function.

[eroman, 2009-07-07 17:45:53]

LGTM.

For the CL description, can you file a bug and link to it with BUG= instead?

http://codereview.chromium.org/149242/diff/1/2
File net/socket/socks_client_socket.cc (right):

http://codereview.chromium.org/149242/diff/1/2#newcode379
Line 379: socklen_t *namelen) {
nit: de-indent by 1 space; also, please move the asterisk to the left.

http://codereview.chromium.org/149242/diff/1/3
File net/socket/socks_client_socket.h (right):

http://codereview.chromium.org/149242/diff/1/3#newcode52
Line 52: virtual int GetPeerName(struct sockaddr *name, socklen_t *namelen);
nit: please move the asterisk to the left.

http://codereview.chromium.org/149242/diff/1/4
File net/socket/socks_client_socket_unittest.cc (right):

http://codereview.chromium.org/149242/diff/1/4#newcode247
Line 247: request.append(hostname.c_str());
no need to convert to c-string:

request.append(hostname);

http://codereview.chromium.org/149242/diff/1/4#newcode275
Line 275: request.push_back('\0');
These changes seem unrelated to the bugfix.
Does this modify the behavior of the test?

[Arindam, 2009-07-08 02:34:54]

Fixed the nit changes.

Added the crbug and linked this CL with it.

http://codereview.chromium.org/149242/diff/1/2
File net/socket/socks_client_socket.cc (right):

http://codereview.chromium.org/149242/diff/1/2#newcode379
Line 379: socklen_t *namelen) {
On 2009/07/07 17:45:53, eroman wrote:
> nit: de-indent by 1 space; also, please move the asterisk to the left.

Done.

http://codereview.chromium.org/149242/diff/1/3
File net/socket/socks_client_socket.h (right):

http://codereview.chromium.org/149242/diff/1/3#newcode52
Line 52: virtual int GetPeerName(struct sockaddr *name, socklen_t *namelen);
On 2009/07/07 17:45:53, eroman wrote:
> nit: please move the asterisk to the left.

Done.

http://codereview.chromium.org/149242/diff/1/4
File net/socket/socks_client_socket_unittest.cc (right):

http://codereview.chromium.org/149242/diff/1/4#newcode247
Line 247: request.append(hostname.c_str());
On 2009/07/07 17:45:53, eroman wrote:
> no need to convert to c-string:
> 
> request.append(hostname);
> 

Done.

http://codereview.chromium.org/149242/diff/1/4#newcode275
Line 275: request.push_back('\0');
On 2009/07/07 17:45:53, eroman wrote:
> These changes seem unrelated to the bugfix.
> Does this modify the behavior of the test?
This file was included by mistake. Removing it from this CL.

[eroman, 2009-07-08 04:25:14]

LGTM