Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 149233: Adds a way to set the boundaries of the browser window through... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)
Modified:
9 years, 3 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Adds a way to set the boundaries of the browser window through automation and use that to set the size of the window in the "New Tab Cold" to ensure we are testing the normal case and not the small case. BUG=None TEST=The NewTabUIStartupTest, PerfCold should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20124

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/automation/window_proxy.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/startup/feature_startup_test.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-07 00:28:42 UTC) #1
stoyan
lgtm http://codereview.chromium.org/149233/diff/1008/32 File chrome/browser/automation/automation_provider.cc (right): http://codereview.chromium.org/149233/diff/1008/32#newcode1717 Line 1717: void AutomationProvider::SetWindowBounds(int handle, const gfx::Rect& bounds, This ...
11 years, 5 months ago (2009-07-07 16:27:45 UTC) #2
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-08 00:11:14 UTC) #3
I had to add SetWindowBounds to temp_scaffolding_stubs.cc

http://codereview.chromium.org/149233/diff/1008/32
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/149233/diff/1008/32#newcode1717
Line 1717: void AutomationProvider::SetWindowBounds(int handle, const gfx::Rect&
bounds,
On 2009/07/07 16:27:46, stoyan wrote:
> This method is wrapped in 
> #if defined(OS_WIN) [line 1559 up to line 1745]; mac and linux builds ->
unhappy
> 

Done.

http://codereview.chromium.org/149233/diff/1008/32#newcode1725
Line 1725: ::MoveWindow(hwnd, bounds.x(), bounds.y(), bounds.width(),
bounds.height(),
On 2009/07/07 16:27:46, stoyan wrote:
> Perhaps *sucess = ::MoveWindow(..)?
> Just in case.

Done.

Powered by Google App Engine
This is Rietveld 408576698