Issue 149220: The default ping delay should be 90 seconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149220: The default ping delay should be 90 seconds. (Closed)

Created:
11 years, 5 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Glenn Wilson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

The default ping delay should be 90 seconds. BUG=1953127 Committed: http://src.chromium.org/viewvc/19995

Patch Set 2 : seconds not milliseconds #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/installer/util/master_preferences.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Glenn Wilson

http://codereview.chromium.org/149220/diff/1/2 File chrome/installer/util/master_preferences.cc (right): http://codereview.chromium.org/149220/diff/1/2#newcode84 Line 84: delay = 90 * 1000; This should probably ...

11 years, 5 months ago (2009-07-06 22:30:21 UTC) #2

kuchhal

11 years, 5 months ago (2009-07-06 22:32:43 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 149220: The default ping delay should be 90 seconds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : seconds not milliseconds #

Messages