Correctly handle multiple control response lines in new FTP transaction

Correctly handle multiple control response lines in new FTP transaction

After this change it should correctly handle all cases of multiple 230 welcome responses. It also fixes some other related bugs.

TEST=Covered by net_unittests.
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20148

[eroman, 2009-07-06 22:13:52]

lgtm as long as <http://codereview.chromium.org/149211/diff/13/1001#newcode207>
is not a potential crash source.

http://codereview.chromium.org/149211/diff/13/1001
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/149211/diff/13/1001#newcode207
Line 207: while (ctrl_responses_.size() != 1) {
Can it be that ctrl_responses_.size() == 0?

(in which case, this loop is entered and may result in crash).

http://codereview.chromium.org/149211/diff/13/1003
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/149211/diff/13/1003#newcode270
Line 270: while (!reads_.empty())
is there not a clear() method on std::queue?

If not, how about using std::vector<> or std::dequeue<> instead?

http://codereview.chromium.org/149211/diff/13/1004
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/149211/diff/13/1004#newcode9
Line 9: #include <queue>
please order this before string.

[Paweł Hajdan Jr., 2009-07-06 23:40:42]

Now it should be ok. Please take a look.

[eroman, 2009-07-06 23:45:12]

lgtm