Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 149210: Re-delete V8Binding and use the upstreamed version (Closed)

Created:
11 years, 5 months ago by Nate Chapin
Modified:
9 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Identical to http://codereview.chromium.org/155030 except for the WebKit revision number in DEPS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20075

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -269 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/bindings/v8/v8_binding.h View 1 1 chunk +0 lines, -135 lines 0 comments Download
D webkit/port/bindings/v8/v8_binding.cpp View 1 1 chunk +0 lines, -130 lines 0 comments Download
M webkit/webkit.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nate Chapin
11 years, 5 months ago (2009-07-07 20:08:55 UTC) #1
Alpha Left Google
11 years, 5 months ago (2009-07-07 20:10:16 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698