Only force-abort popup render views on mousedown....

Only force-abort popup render views on mousedown.

BUG= http://crbug.com/15976
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19998

[Evan Martin, 2009-07-06 20:51:15]

I really don't understand this code well enough to say much intelligent about it

http://codereview.chromium.org/149209/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/149209/diff/1/2#newcode239
Line 239: !host_view->is_popup_first_mouse_release_ && !click_in_popup) {
Do you need all these additional tests here, or is testing just what the comment
says sufficient?  The comment you deleted discusses some of the other bits you
test.

[Evan Stade, 2009-07-06 21:05:16]

http://codereview.chromium.org/149209/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/149209/diff/1/2#newcode239
Line 239: !host_view->is_popup_first_mouse_release_ && !click_in_popup) {
On 2009/07/06 20:51:15, Evan Martin wrote:
> Do you need all these additional tests here, or is testing just what the
comment
> says sufficient?  The comment you deleted discusses some of the other bits you
> test.

all the tests are necessary except |host_view->parent_|, but I left that one in
because there might be some crazy corner case that we haven't thought of that
causes us to get a mouse down outside the render view even though we aren't a
popup and don't have an x pointer grab. I can add a comment explaining that if
you like.

[Evan Stade, 2009-07-06 23:30:46]

updated

[Evan Martin, 2009-07-06 23:32:20]

OK