Issue 149207: Proper fix for the "thousands of macro names must be identifiers" bug....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149207: Proper fix for the "thousands of macro names must be identifiers" bug.... (Closed)

Created:
11 years, 5 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Proper fix for the "thousands of macro names must be identifiers" bug. This is all mmentovai. I am just a copier/paster. R=mark BUG=15904 TEST=no more "macro names must be identifiers" errors during V8 bindings generation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19972

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed obsolete comment. #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	webkit/build/rule_binding.py	View	1	2 chunks	+11 lines, -3 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/149207/diff/1/2 File webkit/build/rule_binding.py (right): http://codereview.chromium.org/149207/diff/1/2#newcode86 Line 86: # Remove any qouble qoutes that may have ...

11 years, 5 months ago (2009-07-06 18:21:06 UTC) #2

Mark Mentovai

LG otherwise. http://codereview.chromium.org/149207/diff/1003/1004 File webkit/build/rule_binding.py (right): http://codereview.chromium.org/149207/diff/1003/1004#newcode78 Line 78: options[defines_index + 1:defines_index + 2] = ...

11 years, 5 months ago (2009-07-06 18:26:47 UTC) #5

dglazkov

11 years, 5 months ago (2009-07-06 18:34:16 UTC) #6

Thanks! I learn Python by flinging my crappy code at you guys and seeing what
response might be. It's a great strategy, really.

Expand Messages | Collapse Messages