Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 149205: Fixing a crash in RenderViewGone.... (Closed)

Created:
11 years, 5 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Fixing a crash in RenderViewGone. If I start Chrome and shut it down quickly RenderViewHost receives an IPC ViewHostMsg_RenderViewGone. We respond in ExtensionHost::RenderViewGone by putting up an info bar on the selected tab contents saying that an extension crashed. Only problem is that ExtensionHost::GetBrowser() can return NULL during startup and shutdown, as documented in the function and so we should not try to put up the Infobar if the browser is going away. BUG=None TEST=Open Chrome with extensions enabled and an extension loaded and shut Chrome down as soon as it launches. It should not crash. Might take a few trys to repro. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/extensions/extension_host.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 5 months ago (2009-07-06 17:54:32 UTC) #1
Paweł Hajdan Jr.
11 years, 5 months ago (2009-07-06 17:59:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698