Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 149197: Allow deleting groups of breakpoints (Closed)

Created:
11 years, 5 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev, pfeldman
Visibility:
Public.

Description

In Chrome several tabs may share the same v8 instance. Each of those tabs can be inspected with its own devtools window. When such devtools window closes we need to clear all breakpoints that belong to it. Notion of breakpoint group enables us to do that. Storing the breakpoints on the client(in a different process) would be inreliable since 1) it may crash and 2) some 'setbreakpoint' requests may be not processed yet by the time devtools window closes. Committed: http://code.google.com/p/v8/source/detail?r=2376

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -9 lines) Patch
M src/debug-delay.js View 1 9 chunks +56 lines, -9 lines 0 comments Download
A test/mjsunit/debug-clearbreakpointgroup.js View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 5 months ago (2009-07-06 12:45:09 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/149197/diff/1/3 File src/debug-delay.js (right): http://codereview.chromium.org/149197/diff/1/3#newcode1471 Line 1471: function(request, response) { We should either consistently ...
11 years, 5 months ago (2009-07-07 12:42:19 UTC) #2
yurys
11 years, 5 months ago (2009-07-07 12:48:25 UTC) #3
http://codereview.chromium.org/149197/diff/1/3
File src/debug-delay.js (right):

http://codereview.chromium.org/149197/diff/1/3#newcode1471
Line 1471: function(request, response) {
On 2009/07/07 12:42:20, Mads Ager wrote:
> We should either consistently change to this style or change this one to be on
> the line before (which will make the line too long).

Done.

Powered by Google App Engine
This is Rietveld 408576698