Whenever proxy configurations contain socks and http/https/ftp proxies, socks...

net/proxy/proxy_server.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_SERVER_H_
 #define NET_PROXY_PROXY_SERVER_H_
 
 #include <string>
 
 namespace net {
@@ skipping 46 matching lines @@
 
   // Gets the port portion of the proxy server.
   int port() const;
 
   // Returns the <host>":"<port> string for the proxy server.
   std::string host_and_port() const;
 
   // Parse from an input with format:
   //   [<scheme>"://"]<server>[":"<port>]
   //
-  // Both <scheme> and <port> are optional. If <scheme> is omitted, it will
-  // be assumed as "http". If <port> is omitted, it will be assumed as
+  // Both <scheme> and <port> are optional. If <scheme> is omitted, it will be
+  // assumed as |default_scheme|. If <port> is omitted, it will be assumed as
   // the default port for the chosen scheme (80 for "http", 1080 for "socks").
   //
   // If parsing fails the instance will be set to invalid.
   //
   // Examples:

[eroman, 2009/07/10 21:24:46]

maybe here we should note that default_scheme=SCHEME_HTTP.

// Examples (for |default_scheme=SCHEME_HTTP|).

[Arindam, 2009/07/11 00:53:35]

Done.

   //   "foopy"            {scheme=HTTP, host="foopy", port=80}
   //   "socks4://foopy"   {scheme=SOCKS4, host="foopy", port=1080}
   //   "socks5://foopy"   {scheme=SOCKS5, host="foopy", port=1080}
   //   "http://foopy:17"  {scheme=HTTP, host="foopy", port=17}
   //   "direct://"        {scheme=DIRECT}
   //   "foopy:X"          INVALID -- bad port.
-  static ProxyServer FromURI(const std::string& uri);
+  static ProxyServer FromURI(const std::string& uri, Scheme default_scheme);
   static ProxyServer FromURI(std::string::const_iterator uri_begin,
-                             std::string::const_iterator uri_end);
+                             std::string::const_iterator uri_end,
+                             Scheme default_scheme);
 
   // Format as a URI string. This does the reverse of FromURI.
   std::string ToURI() const;
 
   // Parses from a PAC string result.
   //
   // If <port> is omitted, it will be assumed as the default port for the
   // chosen scheme (80 for "http", 1080 for "socks").
   //
   // If parsing fails the instance will be set to invalid.
@@ skipping 29 matching lines @@
       std::string::const_iterator host_and_port_end);
 
   Scheme scheme_;
   std::string host_;
   int port_;
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_SERVER_H_