Issue 149188: Fix the order in which ToNumber is called for some Math functions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149188: Fix the order in which ToNumber is called for some Math functions.... (Closed)

Created:
11 years, 5 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix the order in which ToNumber is called for some Math functions. Avoid divisions when doing Math.min(0, 0). https://bugs.webkit.org/show_bug.cgi?id=26978 has been filed to fix inconsistencies between JSC and V8. Committed: http://code.google.com/p/v8/source/detail?r=2367

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -9 lines)			Patch
	M	src/math.js	View	1	3 chunks	+13 lines, -9 lines	0 comments	Download
	A	test/mjsunit/to_number_order.js	View	1	1 chunk	+102 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik Corry

11 years, 5 months ago (2009-07-05 15:00:03 UTC) #3

After finding more inconsistencies I decided to file
https://bugs.webkit.org/show_bug.cgi?id=26978 and to make V8 follow the spec.