Issue 149185: Ensure that VisitedLink listener Add event only fires when new fingerprint is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149185: Ensure that VisitedLink listener Add event only fires when new fingerprint is... (Closed)

Created:
11 years, 5 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Ensure that VisitedLink listener Add event only fires when new fingerprint is added, and not during resizing/rebuilding or deleting fingerprints. R=brettw TEST=VisitedLinkTest.Listener BUG=15926 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19931

Patch Set 1 #

Patch Set 2 : Changed to use method parameter. #

Patch Set 3 : Fixed the comment. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -17 lines)			Patch
M	chrome/browser/visitedlink_master.h	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/visitedlink_master.cc	View	1 2	6 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/visitedlink_unittest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

I find big flags like this kind of undesirable. What do you think about adding ...

11 years, 5 months ago (2009-07-04 16:33:34 UTC) #2

Exactly. LGTM

Expand Messages | Collapse Messages