Move Emf class to the printing library. Also creates a platform agnostic Nat...

Move Emf class to the printing library.  Also creates a platform agnostic NativeMetafile definition to ease platform porting.

BUG=none
TEST=none (No functional change)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19943

[Sverrir, 2009-07-03 18:54:34]

This is not perfect but still step in the right direction.  I can't forward
declare the new NativeMetafile typedef so I had to include the header file in a
couple of places.
I also used emf_win.h include in one place where the file is _win.cc.

[Sverrir, 2009-07-03 18:57:49]

Added missing files...

[M-A Ruel, 2009-07-03 19:52:50]

The code lgtm but you need to fix check_deps and compilation on windows first.

http://codereview.chromium.org/149181/diff/1055/1069
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/149181/diff/1055/1069#newcode105
Line 105: NativeMetafile* metafile = new NativeMetafile();
While changing it, do you mind:
scoped_ptr<NativeMetafile> metafile(new NativeMetafile());
delete line 108
change line 114 to metafile.release()

[Sverrir, 2009-07-03 22:03:09]

Missed one file that I just added.  Will submit on green bots...

http://codereview.chromium.org/149181/diff/1055/1069
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/149181/diff/1055/1069#newcode105
Line 105: NativeMetafile* metafile = new NativeMetafile();
On 2009/07/03 19:52:51, Marc-Antoine Ruel wrote:
> While changing it, do you mind:
> scoped_ptr<NativeMetafile> metafile(new NativeMetafile());
> delete line 108
> change line 114 to metafile.release()

Done.

[brettw, 2009-07-04 05:36:25]

> Missed one file that I just added.  Will submit on green bots...

You haven'd addressed the checkdeps failure.

Why is there a toplevel printing directory? Is it supposed to be usable outside
of Chrome? By whom? If this is true, you can't include chrome code, as checkdeps
is pointing out.

[M-A Ruel, 2009-07-04 12:29:59]

On 2009/07/04 05:36:25, brettw wrote:
> 
> Why is there a toplevel printing directory? Is it supposed to be usable
outside
> of Chrome? By whom? If this is true, you can't include chrome code, as
checkdeps
> is pointing out.

No it can't include chrome/ code, I overlooked that. It's mainly for testing
directly in test shell.

[Sverrir, 2009-07-06 14:13:06]

On 2009/07/04 12:29:59, Marc-Antoine Ruel wrote:
> On 2009/07/04 05:36:25, brettw wrote:
> > 
> > Why is there a toplevel printing directory? Is it supposed to be usable
> outside
> > of Chrome? By whom? If this is true, you can't include chrome code, as
> checkdeps
> > is pointing out.
> 
> No it can't include chrome/ code, I overlooked that. It's mainly for testing
> directly in test shell.

I forgot to remove that last include - done now.  It was used by the test I
disabled.

I'm trying to prepare for cross platform porting and trying to draw out more
reusable components and simplify dependencies.  There are no external usages
planned that I know of but this has been requested (in  bug comments).