Issue 149178: DevTools: Console tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149178: DevTools: Console tests. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Console tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19904

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -12 lines)			Patch
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
A	chrome/test/data/devtools/console_test_page.html	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools_host_stub.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/tests.js	View	5 chunks	+97 lines, -12 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

11 years, 5 months ago (2009-07-03 11:07:05 UTC) #2

LGTM

http://codereview.chromium.org/149178/diff/1/5
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/149178/diff/1/5#newcode301
Line 301: controller.reportOk();
remove this?

http://codereview.chromium.org/149178/diff/1/5#newcode311
Line 311: TestSuite.ConsoleEnter = {
ConsoleEnterEvent would sound better

Expand Messages | Collapse Messages