Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 149176: Don't send script source in afterCompile event (Closed)

Created:
11 years, 5 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

We've got complains that sending afterCompile events to debug message handler may have considerable impact on the profiler when inspected script does lots of 'eval's. The proposed solution is to request source of the compiled script lazily instead of sending it in afterCompile event. Corresponding Chromium bug: http://code.google.com/p/chromium/issues/detail?id=15913 Committed: http://code.google.com/p/v8/source/detail?r=2349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/debug-delay.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
11 years, 5 months ago (2009-07-03 09:55:33 UTC) #1
Mads Ager (chromium)
11 years, 5 months ago (2009-07-03 09:59:27 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698