Issue 149173: A null CGImageRef should be treated as a "null" SkBitmap,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149173: A null CGImageRef should be treated as a "null" SkBitmap,... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A null CGImageRef should be treated as a "null" SkBitmap, one in which isNull() returns true. This assertion was being tripped as a result of some recent changes I made to expose a CGImageRef as the basis or a WebKit::WebImage. I think it makes sense to put this null check in CGImageToSkBitmap instead of at each callsite. TEST=covered by mac ui tests BUG=none TBR=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19900

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	skia/ext/skia_utils_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages